Update dependencies (#15869)

* Update dependencies

* fix new phpstan errors

* Update phpstan.neon

LibreNMS/Alert/Transport/Pagerduty.php

@@ -41,7 +41,9 @@ class Pagerduty extends Transport
         };
 
         $safe_message = strip_tags($alert_data['msg']) ?: 'Test';
-        $message = array_filter(explode("\n", $safe_message), 'strlen');
+        $message = array_filter(explode("\n", $safe_message), function ($value): bool {
+            return strlen($value) > 0;
+        });
         $data = [
             'routing_key' => $this->config['service_key'],
             'event_action' => $event_action,

composer.json

@@ -2,7 +2,8 @@
     "name": "librenms/librenms",
     "type": "project",
     "description": "A fully featured network monitoring system that provides a wealth of features and device support.",
-    "keywords": [
+    "keywords":
+    [
         "network",
         "monitoring",
         "discovery",
@@ -13,7 +14,8 @@
     ],
     "homepage": "https://www.librenms.org/",
     "license": "GPL-3.0-or-later",
-    "require": {
+    "require":
+    {
         "php": "^8.1",
         "ext-curl": "*",
         "ext-gd": "*",
@@ -55,46 +57,54 @@
         "tecnickcom/tcpdf": "^6.4",
         "tightenco/ziggy": "^1.6.0"
     },
-    "require-dev": {
+    "require-dev":
+    {
         "barryvdh/laravel-debugbar": "^3.8",
         "barryvdh/laravel-ide-helper": "^2.13",
         "composer/composer": "^2.4",
         "fakerphp/faker": "^1.9.1",
         "friendsofphp/php-cs-fixer": "^v3.4",
+        "larastan/larastan": "^2.9",
         "laravel/dusk": "^7.4",
         "mockery/mockery": "^1.4.4",
         "nunomaduro/collision": "^7.0",
-        "nunomaduro/larastan": "^2.4",
         "php-parallel-lint/php-parallel-lint": "^1.1",
         "phpstan/phpstan-deprecation-rules": "^1.0",
         "phpstan/phpstan-mockery": "^1.0",
         "phpunit/phpunit": "^9.5.10"
     },
-    "suggest": {
+    "suggest":
+    {
         "ext-gmp": "Used for browser push notifications",
         "ext-ldap": "*",
         "ext-memcached": "Required if you utilize wrapper based distributed polling",
         "ext-mysqlnd": "*",
         "ext-posix": "Allows for additional validation tests"
     },
-    "config": {
+    "config":
+    {
         "discard-changes": true,
         "optimize-autoloader": true,
         "platform-check": true,
         "preferred-install": "dist",
         "sort-packages": true
     },
-    "extra": {
-        "laravel": {
-            "dont-discover": [
+    "extra":
+    {
+        "laravel":
+        {
+            "dont-discover":
+            [
                 "nunomaduro/laravel-console-summary",
                 "facade/ignition",
                 "socialiteproviders/manager"
             ]
         }
     },
-    "autoload": {
-        "psr-4": {
+    "autoload":
+    {
+        "psr-4":
+        {
             "App\\": "app",
             "LibreNMS\\": "LibreNMS",
             "LibreNMS\\Plugins\\": "html/plugins",
@@ -102,21 +112,26 @@
             "Database\\Factories\\": "database/factories/",
             "Database\\Seeders\\": "database/seeders/"
         },
-        "classmap": [
+        "classmap":
+        [
             "vendor/dapphp/radius"
         ],
-        "files": [
+        "files":
+        [
             "includes/helpers.php"
         ],
-        "exclude-from-classmap": [
+        "exclude-from-classmap":
+        [
             "/vendor/laravel/laravel/database/",
             "/vendor/laravel/laravel/app/",
             "/html/plugins"
         ]
     },
-    "scripts": {
+    "scripts":
+    {
         "pre-install-cmd": "LibreNMS\\ComposerHelper::preInstall",
-        "post-install-cmd": [
+        "post-install-cmd":
+        [
             "LibreNMS\\ComposerHelper::postInstall",
             "Illuminate\\Foundation\\ComposerScripts::postInstall",
             "@php artisan vue-i18n:generate --multi-locales --format=umd",
@@ -126,29 +141,35 @@
             "@python-requirements"
         ],
         "pre-update-cmd": "LibreNMS\\ComposerHelper::preUpdate",
-        "post-update-cmd": [
+        "post-update-cmd":
+        [
             "Illuminate\\Foundation\\ComposerScripts::postUpdate"
         ],
-        "post-autoload-dump": [
+        "post-autoload-dump":
+        [
             "Illuminate\\Foundation\\ComposerScripts::postAutoloadDump",
             "@php artisan package:discover --ansi"
         ],
         "post-root-package-install": "LibreNMS\\ComposerHelper::postRootPackageInstall",
-        "post-create-project-cmd": [
+        "post-create-project-cmd":
+        [
             "@php artisan key:generate --ansi"
         ],
-        "python-requirements": [
+        "python-requirements":
+        [
             "scripts/dynamic_check_requirements.py || pip3 install --user -r requirements.txt || :"
         ]
     },
-    "support": {
+    "support":
+    {
         "issues": "https://github.com/librenms/librenms/issues/",
         "forum": "https://community.librenms.org/",
         "chat": "https://discord.gg/librenms",
         "source": "https://github.com/librenms/librenms/",
         "docs": "https://docs.librenms.org/"
     },
-    "funding": [
+    "funding":
+    [
         {
             "type": "opencollective",
             "url": "https://opencollective.com/librenms"

phpstan-baseline.neon

@@ -95,11 +95,6 @@ parameters:
 			count: 1
 			path: LibreNMS/OS/Ios.php
 
-		-
-			message: "#^If condition is always false\\.$#"
-			count: 1
-			path: LibreNMS/OS/Shared/Cisco.php
-
 		-
 			message: "#^Variable \\$index might not be defined\\.$#"
 			count: 2

phpstan.neon

@@ -1,7 +1,7 @@
 includes:
     - phpstan-baseline.neon
     - tests/phpstan/ignore-by-php-version.neon.php
-    - vendor/nunomaduro/larastan/extension.neon
+    - vendor/larastan/larastan/extension.neon
     - vendor/phpstan/phpstan-mockery/extension.neon
 
 parameters: