opensourcemirror
/
Laravel
mirror of https://github.com/laravel/laravel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix PHPUnit bool server consts result in null (#5409) 

After updating to Laravel 8 I suddenly had my test suite failing because telescope would not be disabled properly by `phpunit.xml` anymore.
This changes fixed my test suite.

I've also created a clean Laravel 8 project and added some tests to demonstrate the issue:
908d3405b8

Maybe this needs to be addressed in PHPUnit. However I'm adding this workaround here because it's a viable solution IMHO.
Maybe should add a note on this in the docs and be done with it…?
This commit is contained in:
Martin Hettiger 2020-09-14 15:04:03 +02:00 committed by GitHub
parent ca30159cab
commit 1c4af33b8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
phpunit.xml
View File

@ -26,6 +26,6 @@
<server name="MAIL_MAILER" value="array"/>
<server name="QUEUE_CONNECTION" value="sync"/>
<server name="SESSION_DRIVER" value="array"/>
<server name="TELESCOPE_ENABLED" value="false"/>
<server name="TELESCOPE_ENABLED" value="(false)"/>
</php>
</phpunit>