coreboot-mirror
/
seabios
mirror of https://review.coreboot.org/seabios.git
1
0
Fork 0
Code Issues Releases Wiki Activity

smbios: Use smbios_next() at smbios_romfile_setup() 

Use smbios_next() instead of smbios_21_next(), to make the code
more generic and reusable for SMBIOS 3.0 support.

Note that `qtables_len` is initialized to `ftables->size` instead
of `ep.structure_table_length` now, but both fields are
guaranteed to have exactly the same value.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Eduardo Habkost 2020-12-10 12:32:37 -05:00 committed by Kevin O'Connor
parent 33fa7082b8
commit 34c3fce6e7
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/fw/biostables.c
View File

@ -477,16 +477,17 @@ smbios_romfile_setup(void)
return 0;
}
f_tables->copy(f_tables, qtables, f_tables->size);
ep.structure_table_address = (u32)qtables; /* for smbios_21_next(), below */
qtables_len = f_tables->size;
/* did we get a type 0 structure ? */
for (t0 = smbios_21_next(&ep, NULL); t0; t0 = smbios_21_next(&ep, t0))
for (t0 = smbios_next(qtables, qtables_len, NULL); t0;
t0 = smbios_next(qtables, qtables_len, t0)) {
if (t0->header.type == 0) {
need_t0 = 0;
break;
}
}
qtables_len = ep.structure_table_length;
if (need_t0) {
/* common case: add our own type 0, with 3 strings and 4 '\0's */
u16 t0_len = sizeof(struct smbios_type_0) + strlen(BIOS_NAME) +