From f5502310e2ad02f4a7c3b98faa3a9a2dadf0525e Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 10 Feb 2021 11:08:28 +0100 Subject: [PATCH] nb/intel/sandybridge: Fix description of auto-precharge bit This bit is primarily used to issue RDA commands. There doesn't seem to be any limitation regarding the number of address bits. Change-Id: I2804f67319c9bc736f9086af408853056aabedd6 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/50473 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/northbridge/intel/sandybridge/raminit_common.c | 2 +- src/northbridge/intel/sandybridge/registers/mchbar.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 2c1681870047..b45c44267c8d 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1711,7 +1711,7 @@ static void train_write_flyby(ramctr_timing *ctrl) .rank = slotrank, }, }, - /* DRAM command RD */ + /* DRAM command RDA */ [2] = { .sp_cmd_ctrl = { .command = IOSAV_RD, diff --git a/src/northbridge/intel/sandybridge/registers/mchbar.h b/src/northbridge/intel/sandybridge/registers/mchbar.h index d3df3c0d962f..bdf85dc3b3d0 100644 --- a/src/northbridge/intel/sandybridge/registers/mchbar.h +++ b/src/northbridge/intel/sandybridge/registers/mchbar.h @@ -112,7 +112,7 @@ * end architecture RTL; * * [16] Chip Select mode control. - * [17] Auto Precharge. Only valid when using 10 row bits! + * [17] Auto Precharge. Used to send RDA commands. * * IOSAV_n_SUBSEQ_CTRL_ch(channel, index) * The parameters of the subseq: number of repetitions of the command,