From efa5a463505f09d88e39f8fe847f1da4abb8ac10 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 19 Apr 2021 16:51:22 +0200 Subject: [PATCH] soc/intel/cannonlake: Set DIMM_SPD_SIZE to 512 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All related mainboards are setting DIMM_SPD_SIZE to 512. Therefore, default to 512 in the SoC Kconfig and drop it from related mainboard Kconfigs. Change-Id: Idb6a0e42961eeb490afd76b4aa7d940961991733 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/52513 Reviewed-by: Michael Niewöhner Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- src/mainboard/clevo/cml-u/Kconfig | 4 ---- src/mainboard/google/drallion/Kconfig | 4 ---- src/mainboard/google/hatch/Kconfig | 4 ---- src/mainboard/google/sarien/Kconfig | 4 ---- src/mainboard/prodrive/hermes/Kconfig | 4 ---- src/mainboard/siemens/chili/Kconfig | 4 ---- src/mainboard/system76/gaze15/Kconfig | 4 ---- src/mainboard/system76/lemp9/Kconfig | 4 ---- src/mainboard/system76/oryp5/Kconfig | 4 ---- src/mainboard/system76/whl-u/Kconfig | 4 ---- src/soc/intel/cannonlake/Kconfig | 3 +++ 11 files changed, 3 insertions(+), 40 deletions(-) diff --git a/src/mainboard/clevo/cml-u/Kconfig b/src/mainboard/clevo/cml-u/Kconfig index 17142f32421b..6d388e7ba206 100644 --- a/src/mainboard/clevo/cml-u/Kconfig +++ b/src/mainboard/clevo/cml-u/Kconfig @@ -61,10 +61,6 @@ config DIMM_MAX int default 2 if BOARD_CLEVO_L140CU_BASE -config DIMM_SPD_SIZE - int - default 512 - config VGA_BIOS_ID string default "8086,9b41" diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index fdcbd05b1a3d..31cac26a7646 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -45,10 +45,6 @@ config DIMM_MAX int default 2 -config DIMM_SPD_SIZE - int - default 512 - config DRIVER_TPM_I2C_BUS hex default 0x4 diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 13e4248f3b9b..c4ca4f9bc34c 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -70,10 +70,6 @@ config DIMM_MAX int default 2 -config DIMM_SPD_SIZE - int - default 512 - config ROMSTAGE_SPD_CBFS bool default y if !ROMSTAGE_SPD_SMBUS diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index feed5e9fee01..144e244d1d33 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -40,10 +40,6 @@ config DIMM_MAX int default 2 -config DIMM_SPD_SIZE - int - default 512 - config DRIVER_TPM_I2C_BUS hex default 0x4 diff --git a/src/mainboard/prodrive/hermes/Kconfig b/src/mainboard/prodrive/hermes/Kconfig index 0219e051fc0f..178accefa9ca 100644 --- a/src/mainboard/prodrive/hermes/Kconfig +++ b/src/mainboard/prodrive/hermes/Kconfig @@ -50,10 +50,6 @@ config OVERRIDE_DEVICETREE string default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb" -config DIMM_SPD_SIZE - int - default 512 - config CONSOLE_POST bool default y diff --git a/src/mainboard/siemens/chili/Kconfig b/src/mainboard/siemens/chili/Kconfig index a261abcb435d..4569762d8183 100644 --- a/src/mainboard/siemens/chili/Kconfig +++ b/src/mainboard/siemens/chili/Kconfig @@ -59,10 +59,6 @@ config INTEL_GMA_VBT_FILE string default "src/mainboard/$(MAINBOARDDIR)/variants/$(CONFIG_VARIANT_DIR)/data.vbt" -config DIMM_SPD_SIZE - int - default 512 - config CBFS_SIZE hex default 0xb00000 diff --git a/src/mainboard/system76/gaze15/Kconfig b/src/mainboard/system76/gaze15/Kconfig index 12f94c2f2b14..aefacdd947c3 100644 --- a/src/mainboard/system76/gaze15/Kconfig +++ b/src/mainboard/system76/gaze15/Kconfig @@ -60,10 +60,6 @@ config DIMM_MAX int default 2 -config DIMM_SPD_SIZE - int - default 512 - config VGA_BIOS_ID string default "8086,9bc4" diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index bf2af91d535e..675b738bd881 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -57,10 +57,6 @@ config DIMM_MAX int default 2 -config DIMM_SPD_SIZE - int - default 512 - config VGA_BIOS_FILE string default "pci8086,9b41.rom" diff --git a/src/mainboard/system76/oryp5/Kconfig b/src/mainboard/system76/oryp5/Kconfig index 009633d485b4..7ff1424fec85 100644 --- a/src/mainboard/system76/oryp5/Kconfig +++ b/src/mainboard/system76/oryp5/Kconfig @@ -61,10 +61,6 @@ config DIMM_MAX int default 2 -config DIMM_SPD_SIZE - int - default 512 - config POST_DEVICE bool default n diff --git a/src/mainboard/system76/whl-u/Kconfig b/src/mainboard/system76/whl-u/Kconfig index 2861ce55d1eb..e93b4216c0c9 100644 --- a/src/mainboard/system76/whl-u/Kconfig +++ b/src/mainboard/system76/whl-u/Kconfig @@ -73,10 +73,6 @@ config DIMM_MAX int default 2 -config DIMM_SPD_SIZE - int - default 512 - config POST_DEVICE bool default n diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index d4bedc1396ec..65277f2f0778 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -119,6 +119,9 @@ config MAX_CPUS int default 12 +config DIMM_SPD_SIZE + default 512 + config DCACHE_RAM_BASE default 0xfef00000