coreboot-mirror
/
coreboot
mirror of https://review.coreboot.org/coreboot.git
1
0
Fork 0
Code Issues Releases Wiki Activity

nb/amd/amdmct/mct_ddr3: Remove unused code 

As described in the comment, the BKDG-recommended algorithm causes
problems and isn't being used, so just delete it.

Change-Id: Ib3d4eba7ea2d7f6545613af5670b243bc011275f
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1347325, 1347326
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33269
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Jacob Garber 2019-06-06 12:13:14 -06:00 committed by Patrick Georgi
parent f69c96dd8d
commit 7d881b5189
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c
View File

@ -1213,13 +1213,6 @@ void procConfig(struct MCTStatStruc *pMCTstat, struct DCTStatStruc *pDCTstat, ui
Seed_Fine = (SeedTotal[ByteLane] % 32) + 32;
}
if (Seed_Gross == 0)
Seed_PreGross = 0;
else if (Seed_Gross & 0x1)
Seed_PreGross = 1;
else
Seed_PreGross = 2;
/* The BKDG-recommended algorithm causes problems with registered DIMMs on some systems
* due to the long register delays causing premature total delay wrap-around.
* Attempt to work around this...