From 05400b7a2f903240797dcff1f87b9eb13e57c120 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= Date: Tue, 11 Dec 2018 15:49:04 +0100 Subject: [PATCH] util/util_readme: Don't recommend running this script with "sh" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit util/util_readme/util_readme.sh is specifically a bash script and requires bash-specific features such as "[[". It doesn't work when run with a "sh" shell that only implements POSIX features, such as dash. Thus, tell the user to run the script directly, in which case the #! line is used. Change-Id: I5706ffe857c5a148e9776571a377ad8647f9a4c2 Signed-off-by: Jonathan Neuschäfer Reviewed-on: https://review.coreboot.org/c/30162 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/util_readme/util_readme.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/util_readme/util_readme.sh b/util/util_readme/util_readme.sh index cdd94dcb1ab2..af688c4b0ddf 100755 --- a/util/util_readme/util_readme.sh +++ b/util/util_readme/util_readme.sh @@ -4,7 +4,7 @@ # in `./util` subdirectories # # Execute from root of project. Example: -# `sh util/util_readme/util_readme.sh` +# `util/util_readme/util_readme.sh` UTIL_README_DIR="$(cd "$(dirname "$0")" || exit; pwd -P)" UTIL_DIR=$(dirname "$UTIL_README_DIR")