firmware_builder: add hardware test builds

We were not building the hardware test images as part for the test step.
This replicate functionality in the chromeos-ec ebuid (via cros-ec
eclass). I put a note in that ebuild to update this script if there are
any changes in the future.

BRANCH=none
BUG=chromium:1147953
TEST=verify that firmware_builder.py --metrics /tmp/m test failed the
same was the cq-orchestrator failed

Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I20937381da41d933261926d02d45b80d3920443b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2535310
Reviewed-by: LaMont Jones <lamontjones@chromium.org>

firmware_builder.py

@@ -34,8 +34,19 @@ def test(opts):
     metrics = firmware_pb2.FwTestMetricList()
     with open(opts.metrics, 'w') as f:
         f.write(json_format.MessageToJson(metrics))
-    return subprocess.run(['make', 'runtests', '-j{}'.format(opts.cpus)],
-                          cwd=os.path.dirname(__file__)).returncode
+
+    # Verify all posix-based unit tests build and pass
+    rv = subprocess.run(['make', 'runtests', '-j{}'.format(opts.cpus)],
+                        cwd=os.path.dirname(__file__)).returncode
+    if rv != 0:
+        return rv
+
+    # Verify compilation of the on-device unit test binaries.
+    # TODO(b/172501728) These should build  for all boards, but they've bit
+    # rotted, so we only build the ones that compile.
+    return subprocess.run(
+        ['make', 'BOARD=bloonchipper', 'tests', '-j{}'.format(opts.cpus)],
+        cwd=os.path.dirname(__file__)).returncode
 
 
 def main(args):