cr50: use single __packed definition

Various parts of Cr50 code and Cr50 related utilities duplicate
definition of __packed available in include/common.h. Let's use the
same definition everywhere.

BRANCH=cr50, cr50-mp
BUG=none
TEST=make buildall succeeds
     verified that linker generated map files for Cr50 RW are the same
     before and after this change.

     built and used gsctoo and rma_reset

Change-Id: Ib91f9bbad1f6822b347f32b393630f592df80d60
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/931929
Reviewed-by: Randall Spangler <rspangler@chromium.org>
(cherry picked from commit 58759f5fbb)
Reviewed-on: https://chromium-review.googlesource.com/942116

chip/g/upgrade_fw.h

@@ -8,6 +8,7 @@
 
 #include <stddef.h>
 
+#include "common.h"  /* For __packed. */
 
 /*
  * This file contains structures used to facilitate cr50 firmware updates,

extra/rma_reset/rma_reset.c

@@ -13,7 +13,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
-#define __packed __attribute__((packed))
+
 #include "rma_auth.h"
 #include "curve25519.h"
 #include "sha256.h"

extra/usb_updater/gsctool.c

@@ -20,11 +20,6 @@
 #include <termios.h>
 #include <unistd.h>
 
-
-#ifndef __packed
-#define __packed __attribute__((packed))
-#endif
-
 #include "config.h"
 
 #include "ccd_config.h"

include/rma_auth.h

@@ -10,6 +10,8 @@
 
 #include <stdint.h>
 
+#include "common.h"  /* For __packed. */
+
 /* Current challenge protocol version */
 #define RMA_CHALLENGE_VERSION 0
 

include/tpm_vendor_cmds.h

@@ -6,6 +6,8 @@
 #ifndef __INCLUDE_TPM_VENDOR_CMDS_H
 #define __INCLUDE_TPM_VENDOR_CMDS_H
 
+#include "common.h"  /* For __packed. */
+
 /*
  * This file includes definitions of extended/vendor TPM2 commands and their
  * return codes. The definitions are shared between the embedded code and the