coreboot-mirror
/
chrome-ec
mirror of https://review.coreboot.org/chrome-ec.git
1
0
Fork 0
Code Issues Releases Wiki Activity

power/cometlake-discrete: stub out espi reset handler 

This appears to be an artifact left over from skylake (where the EC
can't turn off the AP without also turning itself off) that was copied
into cometlake and from there into cometlake-discrete. Since we never
mess with the power button like skylake does, there's no reason to
include that handling.

TEST=no effect on puff's behavior
BUG=None
BRANCH=None

Change-Id: Id383e5b7b28e7cca7c5f5e1fb0d8840a1c15bffa
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2014002
Reviewed-by: Andrew McRae <amcrae@chromium.org>
This commit is contained in:
Peter Marheine 2020-01-22 13:44:45 +11:00 committed by Commit Bot
parent f1519c5b4e
commit be95f2907d
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
power/cometlake-discrete.c
View File

@ -204,17 +204,7 @@ void chipset_force_shutdown(enum chipset_shutdown_reason reason)
shutdown_s5_rails();
}
void chipset_handle_espi_reset_assert(void)
{
/*
* If eSPI_Reset# pin is asserted without SLP_SUS# being asserted, then
* it means that there is an unexpected power loss (global reset
* event). In this case, check if shutdown was being forced by pressing
* power button. If yes, release power button.
*/
if ((power_get_signals() & IN_PGOOD_ALL_CORE))
power_button_pch_release();
}
void chipset_handle_espi_reset_assert(void) {}
enum power_state chipset_force_g3(void)
{