coreboot-mirror
/
chrome-ec
mirror of https://review.coreboot.org/chrome-ec.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Flapjack: Fix bit size for LCM_ID 

LCM_ID's bit size is 4. Thus, PANEL_UNINITIALIZED should be 0xf.
This fixes 'bitwise comparison always evaluates to false' error.

Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>

Cq-Depend: chromium:1586582
BUG=none
BRANCH=none
TEST=make BOARD=flapjack

Change-Id: Ib9c43cb7b929f902cdced627e1d40669ae365775
Reviewed-on: https://chromium-review.googlesource.com/1585398
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
This commit is contained in:
Daisuke Nojiri 2019-04-26 10:33:51 -07:00 committed by chrome-bot
parent 4750cd2422
commit 961c0d0fdc
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
board/flapjack/board.c
View File

@ -61,6 +61,7 @@ static const struct mv_to_id panels[] = {
{ PANEL_BOE_HIMAX8279D8P, 280 },
};
BUILD_ASSERT(ARRAY_SIZE(panels) < PANEL_COUNT);
BUILD_ASSERT(PANEL_COUNT <= PANEL_UNINITIALIZED);
uint16_t board_version;
uint8_t oem;

2
board/flapjack/board.h
View File

@ -262,7 +262,7 @@ enum panel_id {
PANEL_BOE_HIMAX8279D10P,
PANEL_BOE_HIMAX8279D8P,
PANEL_COUNT,
PANEL_UNINITIALIZED = 0xff,
PANEL_UNINITIALIZED = 0xf,
};
/* power signal definitions */