coreboot-mirror
/
chrome-ec
mirror of https://review.coreboot.org/chrome-ec.git
1
0
Fork 0
Code Issues Releases Wiki Activity

cometlake: Remove TODO comment from chipset_force_shutdown 

There was a todo to replace a while loop with a call to
power_wait_signals_timeout. However, using that function is not
feasible in this case as it's only intended to check for power signals
that are high. Removing the TODO comment since it's not applicable.

BUG=b:122264541
BRANCH=None
TEST=make BOARD=hatch

Change-Id: I0dca060f8a8e00bc99a433d78dd55d262a867cb1
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1783521
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
This commit is contained in:
Scott Collyer 2019-09-03 16:43:42 -07:00 committed by Commit Bot
parent eac716b4f6
commit 8f47673f34
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
power/cometlake.c
View File

@ -78,10 +78,6 @@ void chipset_force_shutdown(enum chipset_shutdown_reason reason)
/* Need to wait a min of 10 msec before check for power good */
msleep(10);
/*
* TODO(b/122264541): Replace this wait with
* power_wait_signals_timeout()
*/
/* Now wait for PP5000_A and RSMRST_L to go low */
while ((gpio_get_level(GPIO_PP5000_A_PG_OD) ||
power_has_signals(IN_PGOOD_ALL_CORE)) && (timeout_ms > 0)) {