coreboot-mirror
/
chrome-ec
mirror of https://review.coreboot.org/chrome-ec.git
1
0
Fork 0
Code Issues Releases Wiki Activity

lantis: Update OCPC PID constants 

This CL updates the OCPC PID constants along with crrev.com/c/2567036
since lantis was initialed with drawcia's image.

BUG=b:174167890
BRANCH=dedede
TEST=Verify that at low SOC, charging from the sub board results in
lower overshoot and reduced time to correct steady state error.

Signed-off-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com>
Change-Id: If4f40913e533901fa6b8280857b480adb8c68e11
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2589134
Reviewed-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
This commit is contained in:
Tommy Chung 2020-12-14 09:38:04 +08:00 committed by Commit Bot
parent 04f7c1ed1b
commit 51c9774be2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
board/lantis/board.c
View File

@ -653,10 +653,10 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div,
int *kd, int *kd_div)
{
*kp = 3;
*kp_div = 14;
*kp_div = 20;
*ki = 3;
*ki_div = 500;
*ki_div = 125;
*kd = 4;
*kd_div = 40;