zephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity

eth: mcux: Do not set carrier ON if interface is not known 

It is possible that the network interface is not yet initialized
when status of the PHY changes. In this case we must not call
net_eth_carrier_on() as that will cause a crash.
This was noticed with mimxrt1050_evk board.

Fixes: #21257

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2019-12-11 13:07:28 +02:00 committed by Anas Nashif
parent b3ef76cb46
commit b41757d338
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/ethernet/eth_mcux.c
View File

@ -327,8 +327,12 @@ static void eth_mcux_phy_event(struct eth_context *context)
kENET_MiiReadValidFrame);
context->link_up = link_up;
context->phy_state = eth_mcux_phy_state_read_duplex;
net_eth_carrier_on(context->iface);
k_sleep(USEC_PER_MSEC);
/* Network interface might be NULL at this point */
if (context->iface) {
net_eth_carrier_on(context->iface);
k_sleep(USEC_PER_MSEC);
}
} else if (!link_up && context->link_up) {
LOG_INF("Link down");
context->link_up = link_up;