zephyr
/
nrf_hw_models
mirror of https://github.com/zephyrproject-rtos/nrf_hw_models.git
1
0
Fork 0
Code Issues Releases Wiki Activity

UART: FIFO backend: Check for failure of fcntl 

As a minor safety check that fcntl succedded.
Also, be explicity about the fact that we are purposedly
discarding the returns from close() and remove() on cleanup.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
This commit is contained in:
Alberto Escolar Piedras 2024-01-17 09:24:53 +01:00
parent 6b6ae3652c
commit cf41110b28
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/HW_models/NHW_UART_backend_fifo.c
View File

@ -649,7 +649,11 @@ static void nhw_ufifo_create_fifos(uint inst, struct ufifo_st_t *u_el) {
/* We clear NONBLOCK so the reads block until data is ready */
int flags = fcntl(u_el->fifo_rx, F_GETFL);
flags ^= O_NONBLOCK;
fcntl(u_el->fifo_rx, F_SETFL, flags);
int ret = fcntl(u_el->fifo_rx, F_SETFL, flags);
if (ret == -1) {
bs_trace_error_line("Unexpected error %i,%s\n",ret, strerror(errno));
}
/* We block here until the other side is connected */
u_el->fifo_tx = open(u_el->fifo_Tx_path, O_WRONLY);
@ -666,15 +670,15 @@ static void nhw_ufifo_backend_cleanup(void) {
if (!u_el->disconnected) {
tx_disconnect(i, u_el);
}
close(u_el->fifo_tx);
(void)close(u_el->fifo_tx);
u_el->fifo_tx = -1;
remove(u_el->fifo_Tx_path); /* The last one closing manages to remove it (so we don't check for success) */
(void)remove(u_el->fifo_Tx_path); /* The last one closing manages to remove it (so we don't check for success) */
u_el->fifo_Tx_path = NULL;
}
if ((u_el->fifo_Rx_path) && (u_el->fifo_rx != -1)) {
close(u_el->fifo_rx);
(void)close(u_el->fifo_rx);
u_el->fifo_rx = -1;
remove(u_el->fifo_Rx_path); /* The last one closing manages to remove it (so we don't check for success) */
(void)remove(u_el->fifo_Rx_path); /* The last one closing manages to remove it (so we don't check for success) */
u_el->fifo_Rx_path = NULL;
}
}