zephyr
/
hal_nordic
mirror of https://github.com/zephyrproject-rtos/hal_nordic.git
1
0
Fork 0
Code Issues Releases Wiki Activity

nrfx_spim: Fix handling of anomaly 109 on nRF52 

The special part of `irq_handler` that handles auxiliary zero-length
transfers has to be executed only when interrupts on the STARTED event
are enabled. Otherwise, each transfer will be repeated indefinitely.

And the STARTED event needs to be cleared before related interrupts
are enabled, as for normal transfers this event is not cleared in the
interrupt handler.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
This commit is contained in:
Andrzej Głąbek 2023-06-20 17:46:11 +02:00
parent 87ed8765a0
commit 7909a532c1
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
nrfx/drivers/src/nrfx_spim.c
View File

@ -736,6 +736,7 @@ static nrfx_err_t spim_xfer(NRF_SPIM_Type * p_spim,
#if NRFX_CHECK(NRFX_SPIM_NRF52_ANOMALY_109_WORKAROUND_ENABLED)
if (flags & NRFX_SPIM_FLAG_HOLD_XFER)
{
nrfy_spim_event_clear(p_spim, NRF_SPIM_EVENT_STARTED);
xfer_desc.tx_length = 0;
xfer_desc.rx_length = 0;
nrfy_spim_int_enable(p_spim, NRF_SPIM_INT_STARTED_MASK);
@ -837,17 +838,14 @@ void nrfx_spim_abort(nrfx_spim_t const * p_instance)
static void irq_handler(NRF_SPIM_Type * p_spim, spim_control_block_t * p_cb)
{
uint32_t evt_mask = nrfy_spim_events_process(p_spim,
#if NRFX_CHECK(NRFX_SPIM_NRF52_ANOMALY_109_WORKAROUND_ENABLED)
NRFY_EVENT_TO_INT_BITMASK(NRF_SPIM_EVENT_STARTED) |
#endif
NRFY_EVENT_TO_INT_BITMASK(NRF_SPIM_EVENT_END),
&p_cb->evt.xfer_desc);
#if NRFX_CHECK(NRFX_SPIM_NRF52_ANOMALY_109_WORKAROUND_ENABLED)
if (evt_mask & NRFY_EVENT_TO_INT_BITMASK(NRF_SPIM_EVENT_STARTED))
if (nrfy_spim_int_enable_check(p_spim, NRF_SPIM_INT_STARTED_MASK) &&
nrfy_spim_event_check(p_spim, NRF_SPIM_EVENT_STARTED))
{
/* Handle first, zero-length, auxiliary transmission. */
nrfy_spim_event_clear(p_spim, NRF_SPIM_EVENT_STARTED);
nrfy_spim_event_clear(p_spim, NRF_SPIM_EVENT_END);
NRFX_ASSERT(nrfy_spim_tx_maxcnt_get(p_spim) == 0);
NRFX_ASSERT(nrfy_spim_rx_maxcnt_get(p_spim) == 0);
@ -861,7 +859,9 @@ static void irq_handler(NRF_SPIM_Type * p_spim, spim_control_block_t * p_cb)
}
#endif
if (evt_mask & NRFY_EVENT_TO_INT_BITMASK(NRF_SPIM_EVENT_END))
if (nrfy_spim_events_process(p_spim,
NRFY_EVENT_TO_INT_BITMASK(NRF_SPIM_EVENT_END),
&p_cb->evt.xfer_desc))
{
#if NRFX_CHECK(NRFX_SPIM3_NRF52840_ANOMALY_198_WORKAROUND_ENABLED)
if (p_spim == NRF_SPIM3)