From 079b0128deecde89e38b9989d90194308db94d8d Mon Sep 17 00:00:00 2001 From: Anton Maklakov Date: Fri, 14 Apr 2017 12:00:59 +0800 Subject: [PATCH 1/6] build: Fix comments and avoid build warning --- components/esp32/test/component.mk | 2 -- components/nghttp/Makefile | 17 ----------------- examples/bluetooth/blufi/main/component.mk | 8 ++------ .../bluetooth/gatt_client/main/component.mk | 10 ++-------- .../bluetooth/gatt_server/main/component.mk | 8 ++------ .../gatt_server_service_table/main/component.mk | 8 ++------ examples/peripherals/i2s/main/component.mk | 8 ++------ 7 files changed, 10 insertions(+), 51 deletions(-) delete mode 100644 components/nghttp/Makefile diff --git a/components/esp32/test/component.mk b/components/esp32/test/component.mk index 5e7d11ddf..745f8cb79 100644 --- a/components/esp32/test/component.mk +++ b/components/esp32/test/component.mk @@ -8,8 +8,6 @@ COMPONENT_ADD_LDFLAGS = -Wl,--whole-archive -l$(COMPONENT_NAME) -Wl,--no-whole-a COMPONENT_SRCDIRS := . test_vectors -include $(IDF_PATH)/make/component_common.mk - test_tjpgd.o: test_tjpgd_logo.h test_tjpgd_logo.h: $(COMPONENT_PATH)/logo.jpg diff --git a/components/nghttp/Makefile b/components/nghttp/Makefile deleted file mode 100644 index ec2514477..000000000 --- a/components/nghttp/Makefile +++ /dev/null @@ -1,17 +0,0 @@ -# -# Component Makefile -# -# This Makefile should, at the very least, just include $(SDK_PATH)/Makefile. By default, -# this will take the sources in this directory, compile them and link them into -# lib(subdirectory_name).a in the build directory. This behaviour is entirely configurable, -# please read the SDK documents if you need to do this. -# -COMPONENT_ADD_INCLUDEDIRS := port/include include - -COMPONENT_SRCDIRS := library port - -#EXTRA_CFLAGS += -DMBEDTLS_CONFIG_FILE='"mbedtls/esp_config.h"' - -EXTRA_CFLAGS := -Wno-error=address -Waddress -DHAVE_CONFIG_H - -include $(IDF_PATH)/make/component.mk \ No newline at end of file diff --git a/examples/bluetooth/blufi/main/component.mk b/examples/bluetooth/blufi/main/component.mk index 79edf031d..a98f634ea 100644 --- a/examples/bluetooth/blufi/main/component.mk +++ b/examples/bluetooth/blufi/main/component.mk @@ -1,8 +1,4 @@ # -# Main Makefile. This is basically the same as a component makefile. -# -# This Makefile should, at the very least, just include $(SDK_PATH)/make/component_common.mk. By default, -# this will take the sources in the src/ directory, compile them and link them into -# lib(subdirectory_name).a in the build directory. This behaviour is entirely configurable, -# please read the ESP-IDF documents if you need to do this. +# "main" pseudo-component makefile. # +# (Uses default behaviour of compiling all source files in directory, adding 'include' to include path.) diff --git a/examples/bluetooth/gatt_client/main/component.mk b/examples/bluetooth/gatt_client/main/component.mk index afcb917c6..a98f634ea 100644 --- a/examples/bluetooth/gatt_client/main/component.mk +++ b/examples/bluetooth/gatt_client/main/component.mk @@ -1,10 +1,4 @@ # -# Main Makefile. This is basically the same as a component makefile. +# "main" pseudo-component makefile. # -# This Makefile should, at the very least, just include $(SDK_PATH)/make/component_common.mk. By default, -# this will take the sources in the src/ directory, compile them and link them into -# lib(subdirectory_name).a in the build directory. This behaviour is entirely configurable, -# please read the ESP-IDF documents if you need to do this. -# - -#include $(IDF_PATH)/make/component_common.mk +# (Uses default behaviour of compiling all source files in directory, adding 'include' to include path.) diff --git a/examples/bluetooth/gatt_server/main/component.mk b/examples/bluetooth/gatt_server/main/component.mk index 79edf031d..a98f634ea 100644 --- a/examples/bluetooth/gatt_server/main/component.mk +++ b/examples/bluetooth/gatt_server/main/component.mk @@ -1,8 +1,4 @@ # -# Main Makefile. This is basically the same as a component makefile. -# -# This Makefile should, at the very least, just include $(SDK_PATH)/make/component_common.mk. By default, -# this will take the sources in the src/ directory, compile them and link them into -# lib(subdirectory_name).a in the build directory. This behaviour is entirely configurable, -# please read the ESP-IDF documents if you need to do this. +# "main" pseudo-component makefile. # +# (Uses default behaviour of compiling all source files in directory, adding 'include' to include path.) diff --git a/examples/bluetooth/gatt_server_service_table/main/component.mk b/examples/bluetooth/gatt_server_service_table/main/component.mk index 79edf031d..a98f634ea 100644 --- a/examples/bluetooth/gatt_server_service_table/main/component.mk +++ b/examples/bluetooth/gatt_server_service_table/main/component.mk @@ -1,8 +1,4 @@ # -# Main Makefile. This is basically the same as a component makefile. -# -# This Makefile should, at the very least, just include $(SDK_PATH)/make/component_common.mk. By default, -# this will take the sources in the src/ directory, compile them and link them into -# lib(subdirectory_name).a in the build directory. This behaviour is entirely configurable, -# please read the ESP-IDF documents if you need to do this. +# "main" pseudo-component makefile. # +# (Uses default behaviour of compiling all source files in directory, adding 'include' to include path.) diff --git a/examples/peripherals/i2s/main/component.mk b/examples/peripherals/i2s/main/component.mk index dbc5a7a9e..9706df8e6 100644 --- a/examples/peripherals/i2s/main/component.mk +++ b/examples/peripherals/i2s/main/component.mk @@ -1,10 +1,6 @@ # -# Main Makefile. This is basically the same as a component makefile. -# -# This Makefile should, at the very least, just include $(SDK_PATH)/make/component.mk. By default, -# this will take the sources in the src/ directory, compile them and link them into -# lib(subdirectory_name).a in the build directory. This behaviour is entirely configurable, -# please read the SDK documents if you need to do this. +# "main" pseudo-component makefile. # +# (Uses default behaviour of compiling all source files in directory, adding 'include' to include path.) COMPONENT_ADD_INCLUDEDIRS := . From 14859cb0fe283f1bd0a8f905a58b0669681a6a3e Mon Sep 17 00:00:00 2001 From: Anton Maklakov Date: Wed, 26 Apr 2017 18:26:21 +0800 Subject: [PATCH 2/6] build: Fix warning if the auto.conf does not exist esp-idf/make/common.mk:10 some/include/config/auto.conf: No such file or directory --- make/common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make/common.mk b/make/common.mk index 41a87b3a6..24aebb4cc 100644 --- a/make/common.mk +++ b/make/common.mk @@ -7,7 +7,7 @@ # (Note that we only rebuild this makefile automatically for some # targets, see project_config.mk for details.) SDKCONFIG_MAKEFILE ?= $(abspath $(BUILD_DIR_BASE)/include/config/auto.conf) -include $(SDKCONFIG_MAKEFILE) +-include $(SDKCONFIG_MAKEFILE) export SDKCONFIG_MAKEFILE # sub-makes (like bootloader) will reuse this path # BATCH_BUILD flag disables interactive terminal features, defaults to verbose build From 2ad9cd36e2cb795ac4d2b30b9129074a81daf81b Mon Sep 17 00:00:00 2001 From: Anton Maklakov Date: Wed, 26 Apr 2017 18:09:14 +0800 Subject: [PATCH 3/6] ci: Reorder the clauses for more convenience --- .gitlab-ci.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 720c06728..47703a588 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -54,11 +54,11 @@ build_template_app: - test $(xtensa-esp32-elf-nm *.a | grep -w ets_printf | wc -l) -eq 0 -.build_gitlab: &build_template +.build_template: &build_template stage: build + image: $CI_DOCKER_REGISTRY/esp32-ci-env tags: - build - image: $CI_DOCKER_REGISTRY/esp32-ci-env variables: SDK_PATH: "$CI_PROJECT_DIR" @@ -176,13 +176,13 @@ test_build_system: test_report: stage: test_report image: $CI_DOCKER_REGISTRY/esp32-ci-env + tags: + - report only: - master - triggers - /^release\/v/ - /^v\d+\.\d+(\.\d+)?($|-)/ - tags: - - report variables: LOG_PATH: "$CI_PROJECT_DIR/$CI_BUILD_REF" TEST_CASE_FILE_PATH: "$CI_PROJECT_DIR/components/idf_test" @@ -228,14 +228,14 @@ push_master_to_github: before_script: - echo "Not setting up GitLab key, not fetching submodules" stage: deploy + image: $CI_DOCKER_REGISTRY/esp32-ci-env + tags: + - deploy only: - master - /^release\/v/ - /^v\d+\.\d+(\.\d+)?($|-)/ - tags: - - deploy when: on_success - image: $CI_DOCKER_REGISTRY/esp32-ci-env variables: GIT_STRATEGY: clone GITHUB_PUSH_REFS: refs/remotes/origin/release refs/remotes/origin/master @@ -261,14 +261,14 @@ deploy_docs: before_script: - echo "Not setting up GitLab key, not fetching submodules" stage: deploy + image: $CI_DOCKER_REGISTRY/esp32-ci-env + tags: + - deploy only: - master - /^release\/v/ - /^v\d+\.\d+(\.\d+)?($|-)/ - triggers - tags: - - deploy - image: $CI_DOCKER_REGISTRY/esp32-ci-env script: - mkdir -p ~/.ssh - chmod 700 ~/.ssh From 3531af91a10a90a5928b11eaa71543babdc93b4e Mon Sep 17 00:00:00 2001 From: Anton Maklakov Date: Wed, 26 Apr 2017 18:30:32 +0800 Subject: [PATCH 4/6] ci: Delete the unused variable --- .gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 47703a588..4cf9a7118 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -29,7 +29,6 @@ build_template_app: - build variables: - SDK_PATH: "$CI_PROJECT_DIR" IDF_PATH: "$CI_PROJECT_DIR" GIT_STRATEGY: clone BATCH_BUILD: "1" @@ -61,7 +60,6 @@ build_template_app: - build variables: - SDK_PATH: "$CI_PROJECT_DIR" IDF_PATH: "$CI_PROJECT_DIR" GIT_STRATEGY: clone BATCH_BUILD: "1" From a2332bc18fc81fa7b826670373d5a401a5a2df63 Mon Sep 17 00:00:00 2001 From: Anton Maklakov Date: Wed, 26 Apr 2017 18:32:30 +0800 Subject: [PATCH 5/6] ci: A config generator doesn't using anymore --- .gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 4cf9a7118..b5efbe6fd 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -317,7 +317,6 @@ check_commit_msg: # commit start with "WIP: " need to be squashed before merge - 'git log --pretty=%s master..${CI_BUILD_REF_NAME} | grep "^WIP: " || exit 0 && exit 1' -# AUTO GENERATED PART START, DO NOT MODIFY CONTENT BELOW # template for test jobs .test_template: &test_template stage: test From 69bf14360d4e007ce4f9f0eb4a3725afbd811510 Mon Sep 17 00:00:00 2001 From: Anton Maklakov Date: Tue, 25 Apr 2017 15:10:32 +0800 Subject: [PATCH 6/6] ci: Fix the incorrect path --- .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b5efbe6fd..25bf66a8b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -185,7 +185,7 @@ test_report: LOG_PATH: "$CI_PROJECT_DIR/$CI_BUILD_REF" TEST_CASE_FILE_PATH: "$CI_PROJECT_DIR/components/idf_test" REPORT_PATH: "$CI_PROJECT_DIR/CI_Test_Report" - MODULE_UPDATE_FILE: "$CI_PROJECT_DIR/tools/unit-test-app/ModuleDefinition.yml" + MODULE_UPDATE_FILE: "$CI_PROJECT_DIR/tools/unit-test-app/tools/ModuleDefinition.yml" artifacts: when: always paths: @@ -336,7 +336,7 @@ check_commit_msg: # append test level folder to TEST_CASE_FILE_PATH in before_script of test job TEST_CASE_FILE_PATH: "$CI_PROJECT_DIR/components/idf_test/integration_test" # jobs MUST set CONFIG_FILE in before_script, and overwrite the variables above if necessary - MODULE_UPDATE_FILE: "$CI_PROJECT_DIR/components/idf_test/unit_test/ModuleDefinition.yml" + MODULE_UPDATE_FILE: "$CI_PROJECT_DIR/tools/unit-test-app/tools/ModuleDefinition.yml" artifacts: when: always