From 036dbce3d0d1af49713d45af9fbbed1ac8f772c6 Mon Sep 17 00:00:00 2001 From: Angus Gratton Date: Mon, 14 May 2018 16:07:27 +0800 Subject: [PATCH] Fix "undefined variable which git" warning when submodules not initialized --- make/project.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make/project.mk b/make/project.mk index a2f26e8f1..01b29bcb3 100644 --- a/make/project.mk +++ b/make/project.mk @@ -511,7 +511,7 @@ check-submodules: $(IDF_PATH)/$(1)/.git $(IDF_PATH)/$(1)/.git: @echo "WARNING: Missing submodule $(1)..." [ -e ${IDF_PATH}/.git ] || ( echo "ERROR: esp-idf must be cloned from git to work."; exit 1) - [ -x $$(which git) ] || ( echo "ERROR: Need to run 'git submodule init $(1)' in esp-idf root directory."; exit 1) + [ -x "$(shell which git)" ] || ( echo "ERROR: Need to run 'git submodule init $(1)' in esp-idf root directory."; exit 1) @echo "Attempting 'git submodule update --init $(1)' in esp-idf root directory..." cd ${IDF_PATH} && git submodule update --init $(1)